-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deps): migrate from archived tslint
to eslint
#509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
- node v14 is EoL and has been since April 2023: https://github.com/nodejs/Release/blob/68840fae8fdaa59bf9431661238dbb86b4390829/README.md?plain=1#L7 - but this is the least intrusive update for now that gets build passing - will further update node in a separate PR Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
added
type/dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
labels
Jan 6, 2024
7 tasks
crenshaw-dev
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test w/ Argo CD UI looks fine. Thanks!
This was referenced Feb 13, 2024
This was referenced May 6, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
type/dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
Supersedes #265 and #428, as well as part of #432 (the
node-version-file
part in the GH Actions)Closes #265, Closes #428
Credit very much given to the original author of those who put in most of the legwork @sosukesuzuki, I am just updating it to get it to pass CI etc
Motivation
tslint
had been officially deprecated in favor ofeslint
with@typescript-eslint
since at least early 2019Config partly mostly double-checked against other
tslint
->eslint
migrations I've worked on recently: argoproj/argo-workflows#12163 and ezolenko/rollup-plugin-typescript2#463overrides
, but it did LGTM in code review of chore: migrates from tslint to eslint #265. Per chore: migrates from tslint to eslint #265 (review), can make further changes as needed after this PR is mergedModifications
Migration changes
lint
script to useeslint
tslint
&tslint-react
to theireslint
/@typescript-eslint
counterpartstslint.json
to.eslintrc.json
@typescript-eslint/no-explicit-any
and@typescript-eslint/no-non-null-assertion
tslint
toeslint
argo-workflows#12163tslint:disable-next-line
comment toeslint-disable-next-line
commentOther necessary or related changes
remove unused
jshintrc
fix various lint errors
{}
->any
or a more specific typeUNSAFE_
prefix to deprecated React methodsupgrade Node version to latest v14 so that install & CI passes with current versions of deps (they require newer Node)
Verification
CI passes