Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): migrate from archived tslint to eslint #509

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Jan 6, 2024

Fixes #264
Supersedes #265 and #428, as well as part of #432 (the node-version-file part in the GH Actions)
Closes #265, Closes #428

Credit very much given to the original author of those who put in most of the legwork @sosukesuzuki, I am just updating it to get it to pass CI etc

Motivation

  • tslint had been officially deprecated in favor of eslint with @typescript-eslint since at least early 2019
    • it's been completely archived since at least mid-2021 as well

Config partly mostly double-checked against other tslint -> eslint migrations I've worked on recently: argoproj/argo-workflows#12163 and ezolenko/rollup-plugin-typescript2#463

Modifications

Migration changes

  • migrate lint script to use eslint
  • migrate tslint & tslint-react to their eslint / @typescript-eslint counterparts
  • migrate tslint.json to .eslintrc.json
    • more or less the same configuration with same plugins
    • use recommended rulesets
    • globally disable @typescript-eslint/no-explicit-any and @typescript-eslint/no-non-null-assertion
  • migrate tslint:disable-next-line comment to eslint-disable-next-line comment

Other necessary or related changes

  • remove unused jshintrc

  • fix various lint errors

    • remove various unused arguments
    • add various missing props
    • {} -> any or a more specific type
    • add UNSAFE_ prefix to deprecated React methods
    • minor automated style changes
  • upgrade Node version to latest v14 so that install & CI passes with current versions of deps (they require newer Node)

Verification

CI passes

sosukesuzuki and others added 10 commits September 2, 2022 20:40
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
Signed-off-by: Sosuke Suzuki <[email protected]>
- node v14 is EoL and has been since April 2023: https://github.com/nodejs/Release/blob/68840fae8fdaa59bf9431661238dbb86b4390829/README.md?plain=1#L7
  - but this is the least intrusive update for now that gets build passing
  - will further update node in a separate PR

Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 added type/dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 6, 2024
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test w/ Argo CD UI looks fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from tslint to eslint
3 participants