Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Rollout/scale to aggregate roles #637

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

dthomson25
Copy link
Member

No description provided.

@dthomson25 dthomson25 changed the title Add Rollout/scale to aggregate roles fix: Add Rollout/scale to aggregate roles Aug 14, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #637 into master will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   85.71%   85.29%   -0.43%     
==========================================
  Files          87       88       +1     
  Lines        8380     8642     +262     
==========================================
+ Hits         7183     7371     +188     
- Misses        859      899      +40     
- Partials      338      372      +34     
Impacted Files Coverage Δ
rollout/service.go 80.00% <0.00%> (-7.39%) ⬇️
rollout/trafficrouting/istio/istio.go 91.72% <0.00%> (-2.35%) ⬇️
rollout/bluegreen.go 81.94% <0.00%> (-0.93%) ⬇️
rollout/canary.go 85.15% <0.00%> (-0.79%) ⬇️
rollout/sync.go 74.00% <0.00%> (-0.75%) ⬇️
.../apis/rollouts/validation/validation_references.go 79.00% <0.00%> (ø)
rollout/controller.go 76.11% <0.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6415a04...9263cd2. Read the comment docs.

Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khhirani khhirani merged commit 806ca6b into argoproj:master Aug 14, 2020
@dthomson25 dthomson25 deleted the agg-role-fix branch August 14, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants