feat: Uplevel AnalysisRun status to Rollout status #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
approved these changes
Jul 21, 2020
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| // CurrentBackgroundAnalysisRun indicates the analysisRun for the Background step | ||
| // TODO(Depreciated): Remove in v0.10 |
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| @@ -550,13 +561,25 @@ type CanaryStatus struct { | |||
| // +optional | |||
| StableRS string `json:"stableRS,omitempty"` | |||
| // CurrentStepAnalysisRun indicates the analysisRun for the current step index | |||
| // TODO(Depreciated): Remove in v0.10 | |||
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| CurrentBackgroundAnalysisRun string `json:"currentBackgroundAnalysisRun,omitempty"` | ||
| // CurrentStepAnalysisRunStatus indicates the status of the current background analysis run |
There was a problem hiding this comment.
Comment should be CurrentBackgroundAnalysisRunStatus
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| // the controller needs to do some specific work when a Rollout is aborted. For example, the reconcileAbort is used | ||
| // to indicate if the Rollout should enter an aborted state when the latest AnalysisRun is a failure, or the controller | ||
| // has already put the Rollout into an aborted and should create a new AnalysisRun. | ||
| ReconciledAbort bool `json:"reconciledAbort,omitempty"` |
There was a problem hiding this comment.
Instead of ReconciledAbort bool, can we have AbortedAt *metav1.Time which gets cleared out whenever Status.Abort = true
dthomson25
force-pushed
the
better-message
branch
from
54e2d7c to
39b5d31
Compare
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 85.80% 85.75% -0.05%
==========================================
Files 87 87
Lines 8297 8376 +79
==========================================
+ Hits 7119 7183 +64
- Misses 844 857 +13
- Partials 334 336 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559