-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Controller Validation #549
Conversation
… values. Add more detailed error messages to validation.go
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 85.92% 85.83% -0.10%
==========================================
Files 86 87 +1
Lines 8136 8130 -6
==========================================
- Hits 6991 6978 -13
- Misses 819 824 +5
- Partials 326 328 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I took a look and have some comments. Let me know if you have any question on them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you have some broken tests. Can you take a look at those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great job!
Create static validation checks for Rollout spec, as described in #358