Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Controller Validation #549

Merged
merged 18 commits into from
Jul 1, 2020
Merged

Conversation

khhirani
Copy link
Contributor

@khhirani khhirani commented Jun 24, 2020

Create static validation checks for Rollout spec, as described in #358

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #549 into master will decrease coverage by 0.09%.
The diff coverage is 91.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   85.92%   85.83%   -0.10%     
==========================================
  Files          86       87       +1     
  Lines        8136     8130       -6     
==========================================
- Hits         6991     6978      -13     
- Misses        819      824       +5     
- Partials      326      328       +2     
Impacted Files Coverage Δ
utils/conditions/conditions.go 80.00% <ø> (-9.24%) ⬇️
rollout/sync.go 74.68% <50.00%> (ø)
pkg/apis/rollouts/validation/validation.go 92.00% <92.00%> (ø)
rollout/controller.go 74.19% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5cd4f...657ae76. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I took a look and have some comments. Let me know if you have any question on them!

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have some broken tests. Can you take a look at those?

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great job!

@khhirani khhirani merged commit 3a0d079 into argoproj:master Jul 1, 2020
@khhirani khhirani deleted the controller-validation branch July 1, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants