Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixes and improvements #437

Merged
merged 2 commits into from
Mar 13, 2020
Merged

docs: fixes and improvements #437

merged 2 commits into from
Mar 13, 2020

Conversation

cronik
Copy link
Contributor

@cronik cronik commented Mar 11, 2020

  • new section for analysis template argments including example for secret references
  • move wavefront analysis example to own section
  • add "not implemented" note for BG post promotion analysis
  • add bluegreen example
  • use tabs to collapse related examples
  • use line highligting to emphasize important config
  • fix admonition indentation
  • footnote in traffic management
  • various formatting fixes
  • initial cut at controller metrics page
  • add ADP to org list

@cronik
docs: fixes and improvements
17f61aa 
- new section for analysis template argments including example for secret references
- move wavefront analysis example to own section
- add "not implemented" note for BG post promotion analysis
- add bluegreen example
- use tabs to collapse related examples
- use line highligting to emphasize important config
- fix admonition indentation
- footnote in traffic management
- various formatting fixes
- initial cut at controller metrics page
- add ADP to org list
@codecov
Copy link

codecov bot commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #437 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   84.79%   84.82%   +0.02%     
==========================================
  Files          74       74              
  Lines        6980     7003      +23     
==========================================
+ Hits         5919     5940      +21     
- Misses        766      767       +1     
- Partials      295      296       +1
Impacted Files Coverage Δ
analysis/analysis.go 85.71% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0d45e...8e967b3. Read the comment docs.

jessesuen
jessesuen reviewed Mar 11, 2020
View reviewed changes
README.md
@@ -15,6 +15,7 @@ To learn more about Argo Rollouts go to the [complete documentation](https://arg
## Who uses Argo Rollouts?
Organizations below are **officially** using Argo Rollouts. Please send a PR with your organization name if you are using Argo Rollouts.

1. [ADP](https://www.adp.com)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 👍 🎉

dthomson25
dthomson25 approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@dthomson25 dthomson25 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking the time to help improve the docs!

@dthomson25 dthomson25 merged commit bdb7e9c into argoproj:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen left review comments

@dthomson25 dthomson25 dthomson25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cronik @dthomson25 @jessesuen