Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use correct podTemplateHashValue attribute for valueFrom #417

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

moensch
Copy link
Contributor

@moensch moensch commented Feb 27, 2020

The valueFrom attribute for analysis args is podTemplateHashValue.

See: https://godoc.org/github.com/argoproj/argo-rollouts/pkg/apis/rollouts/v1alpha1#ArgumentValueFrom

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #417   +/-   ##
======================================
  Coverage    84.5%   84.5%           
======================================
  Files          70      70           
  Lines        6667    6667           
======================================
  Hits         5634    5634           
  Misses        746     746           
  Partials      287     287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f6fd8...43d9421. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit f00e92d into argoproj:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants