Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo in BlueGreen #3463

Merged
merged 1 commit into from
Mar 22, 2024
Merged

docs: typo in BlueGreen #3463

merged 1 commit into from
Mar 22, 2024

Conversation

PatrickChoDev
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (8405f2e) to head (98ae3a0).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3463      +/-   ##
==========================================
+ Coverage   81.83%   82.81%   +0.97%     
==========================================
  Files         135      135              
  Lines       20688    16998    -3690     
==========================================
- Hits        16931    14077    -2854     
+ Misses       2883     2034     -849     
- Partials      874      887      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Go Published Test Results

2 142 tests   2 142 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 98ae3a0.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 43m 18s ⏱️
108 tests  98 ✅  6 💤  4 ❌
442 runs  408 ✅ 24 💤 10 ❌

For more details on these failures, see this check.

Results for commit 98ae3a0.

@zachaller zachaller merged commit d8fecb5 into argoproj:master Mar 22, 2024
21 checks passed
shubhajyoti-bagchi-groww pushed a commit to shubhajyoti-bagchi-groww/argo-rollouts that referenced this pull request Mar 23, 2024
Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>
shubhajyoti-bagchi-groww pushed a commit to shubhajyoti-bagchi-groww/argo-rollouts that referenced this pull request Mar 24, 2024
Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>
zachaller pushed a commit that referenced this pull request Mar 26, 2024
… following a canary abort for istio trafficrouting (#3467)

* chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch from 1.36.1 to 1.36.3 (#3452)

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch

Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.36.1 to 1.36.3.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.36.1...service/ssm/v1.36.3)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* controller: Fixed negative canary weight bug for istio trafficrouting

Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* Added e2e test to validate the fix

Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* Removed local changes

Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* linted as per golangci-lint run

Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* docs: typo in BlueGreen (#3463)

Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* chore(deps): bump slsa-framework/slsa-github-generator from 1.9.1 to 1.10.0 (#3462)

chore(deps): bump slsa-framework/slsa-github-generator

Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases)
- [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
- [Commits](slsa-framework/slsa-github-generator@v1.9.1...v1.10.0)

---
updated-dependencies:
- dependency-name: slsa-framework/slsa-github-generator
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 from 1.30.3 to 1.30.4 (#3461)

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2

Bumps [github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2](https://github.com/aws/aws-sdk-go-v2) from 1.30.3 to 1.30.4.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.30.3...service/s3/v1.30.4)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* Removed sleep and waited for 1 replicas

Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

* Moved up canary weight test to match PR title

Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: shubhajyoti-bagchi-groww <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thanapat Chotipun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants