chore(deps): bump argo-ui and fix browser console errors #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
> allow allowSyntheticDefaultImports Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3212 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 134 134
Lines 20576 20576
=======================================
Hits 16832 16832
Misses 2875 2875
Partials 869 869 ☔ View full report in Codecov by Sentry. |
alexmt
requested changes
Dec 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
@alexmt done |
ashutosh16
pushed a commit
to ashutosh16/argo-rollouts
that referenced
this pull request
Dec 8, 2023
* feat: update argo-ui package Signed-off-by: Mayursinh Sarvaiya <[email protected]> * chore: revert back moment package import > allow allowSyntheticDefaultImports Signed-off-by: Mayursinh Sarvaiya <[email protected]> * fix: browser console errors Signed-off-by: Mayursinh Sarvaiya <[email protected]> --------- Signed-off-by: Mayursinh Sarvaiya <[email protected]> Signed-off-by: ashutosh16 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was looking into rollout extension issue - argoproj-labs/rollout-extension#21, I observed that rollout extension depends on this repo rollout ui, and this repo depends on argo-ui. Argo UI is being updated but the latest versions isn't updated in this repo - https://github.com/argoproj/argo-rollouts/blob/master/ui/yarn.lock#L2702C57-L2702C97. The current repo's argo-ui point directly to the year 2021's commit of argo-ui.
That means old react-toastify which is picked up by rollout-extension and when installed in argo-cd, overrides the react-toastify and notification doesn't look good argoproj-labs/rollout-extension#21 in argocd.
This PR aims to fix that plus update
argo-uidependency plus fix the errors in the browser console - which are breaking extension (i.e. argoproj-labs/rollout-extension#59)Checklist:
"fix(controller): Updates such and such. Fixes #1234".