Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codegen was missed #3104

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: codegen was missed #3104

merged 1 commit into from
Oct 13, 2023

Conversation

zachaller
Copy link
Collaborator

No description provided.

Signed-off-by: zachaller <[email protected]>
@zachaller zachaller changed the title fix: codegen fix: codegen was not ran on a PR Oct 13, 2023
@zachaller zachaller changed the title fix: codegen was not ran on a PR fix: codegen was missed Oct 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.6% 17.6% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (69c697c) 81.71% compared to head (ed3fdac) 81.78%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
+ Coverage   81.71%   81.78%   +0.07%     
==========================================
  Files         134      134              
  Lines       20432    20459      +27     
==========================================
+ Hits        16695    16733      +38     
+ Misses       2876     2863      -13     
- Partials      861      863       +2     
Files Coverage Δ
metricproviders/webmetric/webmetric.go 78.23% <100.00%> (+9.34%) ⬆️
metricproviders/prometheus/prometheus.go 87.42% <86.95%> (+1.80%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Go Published Test Results

2 049 tests   2 049 ✔️  2m 42s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit ed3fdac.

@zachaller zachaller enabled auto-merge (squash) October 13, 2023 18:33
@zachaller zachaller merged commit 1d89c33 into argoproj:master Oct 13, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants