Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add labels to RolloutInfo api object response #3096

Closed
wants to merge 1 commit into from

Conversation

phclark
Copy link
Contributor

@phclark phclark commented Oct 11, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@phclark phclark changed the title feat: Create new table view in Rollouts dashboard feat: add labels to RolloutInfo api object response Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (69c697c) 81.71% compared to head (05de999) 81.78%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3096      +/-   ##
==========================================
+ Coverage   81.71%   81.78%   +0.07%     
==========================================
  Files         134      134              
  Lines       20432    20461      +29     
==========================================
+ Hits        16695    16735      +40     
+ Misses       2876     2863      -13     
- Partials      861      863       +2     
Files Coverage Δ
metricproviders/webmetric/webmetric.go 78.23% <100.00%> (+9.34%) ⬆️
pkg/kubectl-argo-rollouts/info/rollout_info.go 89.74% <100.00%> (+0.10%) ⬆️
metricproviders/prometheus/prometheus.go 87.42% <86.95%> (+1.80%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Go Published Test Results

2 049 tests   2 049 ✔️  2m 42s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 05de999.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 48m 44s ⏱️
102 tests   82 ✔️   6 💤 14
448 runs  384 ✔️ 24 💤 40

For more details on these failures, see this check.

Results for commit 05de999.

♻️ This comment has been updated with latest results.

@phclark phclark changed the title feat: add labels to RolloutInfo api object response chore: add labels to RolloutInfo api object response Oct 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.1% 11.1% Duplication

@zachaller zachaller added this to the v1.7 milestone Oct 13, 2023
@phclark
Copy link
Contributor Author

phclark commented Oct 19, 2023

Closing this PR in favor of #3118

@phclark phclark closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants