Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set StableRS hash to current if replicaset does not actually exist #306

Closed
wants to merge 1 commit into from
Closed

Set StableRS hash to current if replicaset does not actually exist #306

wants to merge 1 commit into from

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Nov 23, 2019 •
edited
Loading

Resolves #305
Will add a unit test

@jessesuen jessesuen requested a review from dthomson25 November 23, 2019 02:46
@dthomson25
Copy link
Member

You mean that this PR solves #305 not #304 right?

dthomson25
dthomson25 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the tests need to be fixed

@dthomson25
Copy link
Member

Closing in favor of #320

@dthomson25 dthomson25 closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthomson25 dthomson25 dthomson25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rollout does not progress current stepIndex when "stable" RS is gone
2 participants
@jessesuen @dthomson25