ci: fix some github actions warnings #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 82.76% // Head: 82.76% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2375 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 121 121
Lines 18536 18536
=======================================
Hits 15341 15341
Misses 2410 2410
Partials 785 785 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zachaller
approved these changes
Oct 27, 2022
thomas-riccardi
force-pushed
the
cleanup-actions-ci
branch
from
bfdb19a
to
0b15a16
Compare
thomas-riccardi
force-pushed
the
cleanup-actions-ci
branch
from
0b15a16
to
b104f87
Compare
zachaller
approved these changes
Oct 28, 2022
6 tasks
The codecov/codecov-action api didn't change with v3. Node.js version was updated from 12 to 16, fixing deprecation warning. See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ Signed-off-by: Thomas Riccardi <[email protected]>
…ifacts from another workflow Signed-off-by: Thomas Riccardi <[email protected]>
since v2 of EnricoMi/publish-unit-test-result-action: warning: Option FILES is deprecated, please use JUNIT_FILES instead! all files are junit format, and are all named junit.xml Signed-off-by: Thomas Riccardi <[email protected]>
thomas-riccardi
force-pushed
the
cleanup-actions-ci
branch
from
b104f87
to
0fae479
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
Nov 8, 2022
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
* bump codecov/codecov-action: v2 to v3 The codecov/codecov-action api didn't change with v3. Node.js version was updated from 12 to 16, fixing deprecation warning. See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ Signed-off-by: Thomas Riccardi <[email protected]> * explain why we can't use native actions/download-artifact: we get artifacts from another workflow Signed-off-by: Thomas Riccardi <[email protected]> * fix publish test result warning since v2 of EnricoMi/publish-unit-test-result-action: warning: Option FILES is deprecated, please use JUNIT_FILES instead! all files are junit format, and are all named junit.xml Signed-off-by: Thomas Riccardi <[email protected]> Signed-off-by: Thomas Riccardi <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
* bump codecov/codecov-action: v2 to v3 The codecov/codecov-action api didn't change with v3. Node.js version was updated from 12 to 16, fixing deprecation warning. See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ Signed-off-by: Thomas Riccardi <[email protected]> * explain why we can't use native actions/download-artifact: we get artifacts from another workflow Signed-off-by: Thomas Riccardi <[email protected]> * fix publish test result warning since v2 of EnricoMi/publish-unit-test-result-action: warning: Option FILES is deprecated, please use JUNIT_FILES instead! all files are junit format, and are all named junit.xml Signed-off-by: Thomas Riccardi <[email protected]> Signed-off-by: Thomas Riccardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeds #1973 and #2251
Checklist:
"fix(controller): Updates such and such. Fixes #1234".