Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollouts demo project containers are not built for arm64 #4125

Open
2 tasks done
dneary opened this issue Feb 10, 2025 · 6 comments
Open
2 tasks done

Rollouts demo project containers are not built for arm64 #4125

dneary opened this issue Feb 10, 2025 · 6 comments
Labels
bug Something isn't working

Comments

@dneary
Copy link

dneary commented Feb 10, 2025

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

The quick start tutorials for the argoproj/argo-rollouts demo do not work on arm64 until at least v1.8.0. The issue is that the rollouts-demo container at https://hub.docker.com/r/argoproj/rollouts-demo is built only on amd64. I am not sure where the demo is built - if I did, I would happily submit some changes to build separate amd64 and arm64 images and create a multiarch manifest.

To Reproduce

To reproduce the bug, install Argo on a Kubernetes cluster running only arm64 nodes, install ArgoCD, and then attempt to walk through the rollouts demo. The rollout will fail because no container is available that can run on the nodes.

Expected behavior

As ArgoCD is supported on multiple architectures, I would expect the "Getting started" documents for it to also work across all supported architectures. I'm happy to help if pointed in the right direction.

Version

Attempted on argocd v1.8.0 - but this is true for all versions because it is not Argo, but the rollouts-demo container, that causes the issue.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@dneary dneary added the bug Something isn't working label Feb 10, 2025
@zachaller
Copy link
Collaborator

zachaller commented Feb 14, 2025

I think the images come from this repo: https://github.com/argoproj/rollouts-demo probably has to be ran manually I don't see any github actions on that repo etc.

@ezejiofor
Copy link

yes please i'm facing the same challenge.
I'm can run rollout on arm64 architecture (multipass) running on my macos.
I can also build the image but how do i build the images with colours? from the tags?
where is the environment variables that is picking the tags?

@zachaller
Copy link
Collaborator

https://github.com/argoproj/rollouts-demo/blob/master/release.sh is how that project seems to be built

@ezejiofor
Copy link

https://github.com/argoproj/rollouts-demo/blob/master/release.sh is how that project seems to be built

Hi @zachaller Thank you so much for the quick response.
Should o just run the release.sh or run the Dockerfile with --platform flag to specify the architecture.
If I go with the second option, will it build the image with six different colours as tags?

@zachaller
Copy link
Collaborator

That repo will need modification to support different platforms, so you would need to modify it. You could also open a PR with the enhancement as well.

@dneary
Copy link
Author

dneary commented Feb 17, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants