Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pprof has broken links #4037

Closed
2 tasks done
DerekTBrown opened this issue Jan 9, 2025 · 1 comment
Closed
2 tasks done

pprof has broken links #4037

DerekTBrown opened this issue Jan 9, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@DerekTBrown
Copy link
Contributor

DerekTBrown commented Jan 9, 2025 •
edited
Loading

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

  • The pprof handler index endpoint is not correctly attached, resulting in 404s when attempting to access certain pprof features.

To Reproduce

  • Enable --enable-pprof-address=:8091
  • kubectl port-forward to the argo-rollouts pod.
  • Connect to the pprof index page (localhost:8091/debug/pprof) then click the goroutine profile.
  • Observe a 404 error.

Expected behavior

  • The above steps properly return the goroutine profile.

Screenshots

Version

  • Tested against master (c0ca5301bfede1532815503cac4461cd0162258f).

Logs

  • N/A

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@DerekTBrown DerekTBrown added the bug Something isn't working label Jan 9, 2025
DerekTBrown added a commit to DerekTBrown/argo-rollouts that referenced this issue Jan 9, 2025
@DerekTBrown
fix(controller): Fixed broken pprof links argoproj#4037
9e4a1ac 
Signed-off-by: Derek Brown <[email protected]>
DerekTBrown added a commit to DerekTBrown/argo-rollouts that referenced this issue Jan 9, 2025
@DerekTBrown
fix(controller): Fixed broken pprof links argoproj#4037
322ccd7 
Signed-off-by: Derek Brown <[email protected]>
DerekTBrown added a commit to DerekTBrown/argo-rollouts that referenced this issue Jan 9, 2025
@DerekTBrown
fix(controller): Fixed broken pprof links argoproj#4037
e026be3 
Signed-off-by: Derek Brown <[email protected]>
@DerekTBrown
Copy link
Contributor Author

Proposed fix: #4038

zachaller pushed a commit that referenced this issue Jan 10, 2025
@DerekTBrown
fix(controller): Fixed broken pprof links #4037 (#4038)
efd3008 
Signed-off-by: Derek Brown <[email protected]>
zachaller pushed a commit that referenced this issue Jan 16, 2025
@DerekTBrown @zachaller
fix(controller): Fixed broken pprof links #4037 (#4038)
e8b557f 
Signed-off-by: Derek Brown <[email protected]>
meeech pushed a commit to CircleCI-Public/argo-rollouts that referenced this issue Feb 10, 2025
@DerekTBrown @meeech
fix(controller): Fixed broken pprof links argoproj#4037 (argoproj#4038)
4f6ba88 
Signed-off-by: Derek Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachaller @DerekTBrown