Skip to content

Commit

Permalink
fix(example): correct docs when metrics got result empty (#2309)
Browse files Browse the repository at this point in the history
* chore(deps): bump github.com/newrelic/newrelic-client-go (#2267)

Bumps [github.com/newrelic/newrelic-client-go](https://github.com/newrelic/newrelic-client-go) from 0.86.5 to 1.0.0.
- [Release notes](https://github.com/newrelic/newrelic-client-go/releases)
- [Changelog](https://github.com/newrelic/newrelic-client-go/blob/main/CHANGELOG.md)
- [Commits](newrelic/newrelic-client-go@v0.86.5...v1.0.0)

---
updated-dependencies:
- dependency-name: github.com/newrelic/newrelic-client-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: hungran <[email protected]>

* fix: correct docs when metrics got result empty

Signed-off-by: hungran <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: hungran <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: zachaller <[email protected]>
  • Loading branch information
3 people authored Nov 8, 2022
1 parent 3f02c92 commit 97ed6de
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/features/analysis.md
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,7 @@ Here are two examples where a metric result of empty array is considered success
apiVersion: argoproj.io/v1alpha1
kind: AnalysisRun
...
successCondition: len(result) == 0 || result >= 0.95
successCondition: len(result) == 0 || result[0] >= 0.95
status:
metricResults:
- count: 1
Expand All @@ -1081,7 +1081,7 @@ status:
apiVersion: argoproj.io/v1alpha1
kind: AnalysisRun
...
successCondition: len(result) > 0 && result >= 0.95
successCondition: len(result) > 0 && result[0] >= 0.95
status:
metricResults:
- count: 1
Expand Down

0 comments on commit 97ed6de

Please sign in to comment.