fix(eventbus): Refine auto-reconnection and bugfix #761
Conversation
whynowy
changed the title
| @@ -4,7 +4,7 @@ RUN yum -y update && yum -y install ca-certificates openssh openssh-server opens | |||
| # Argo Workflow CLI | |||
| COPY assets/argo-linux-amd64 /usr/local/bin/argo | |||
|
|
|||
| RUN argo version | |||
| RUN argo version || true | |||
There was a problem hiding this comment.
Latest argo cli has an issue that it throws an error if no kubeconfig is provided.
There was a problem hiding this comment.
so shall we pin it to a version that doesnt require kubeconfig? or whats the solution?
There was a problem hiding this comment.
It looks like the issue has been fixed in workflow, let me create a PR to release a new CLI version and then we update it.
There was a problem hiding this comment.
It was merged 4 days ago, not in any release.
It only impacts docker build, let's use argo version || true here for now to workaround the issue, and update it later with new CLI.
whynowy
changed the title
| @@ -4,7 +4,7 @@ RUN yum -y update && yum -y install ca-certificates openssh openssh-server opens | |||
| # Argo Workflow CLI | |||
| COPY assets/argo-linux-amd64 /usr/local/bin/argo | |||
|
|
|||
| RUN argo version | |||
| RUN argo version || true | |||
There was a problem hiding this comment.
so shall we pin it to a version that doesnt require kubeconfig? or whats the solution?
There were some cases auto-reconnection didn't work, this change fixes them.
Stop using
reconnectfeature provided by NATS because sometimes there was inconsistent natsConn and stanConn statuses. Handling reconnection in Sensor and EventSource is good enough.