fix: compare errors with string to avoid log spew in jetstream sensor #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sercan Turkmen <[email protected]>
sercant
force-pushed
the
fix-avoid-log-spew-in-jetstream-sensor
branch
from
4b2e2e5 to
2a356f5
Compare
|
Hello @whynowy ! We are submitting this change because on our setup, when one of the NATS Jetstream replica is changing instance (spot), argo-events eventsource emits millions of logs. It would be great if you could take a look at it when you have time. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the error comparison to avoid log spew. Instead of comparing the errors directly, compare the string versions.
Checklist: