feat: Kafka es discontinues processing if eb publishing fails #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
whynowy
changed the title
whynowy
commented
Sep 25, 2022
| @@ -94,7 +94,7 @@ func Convert2WaitBackoff(backoff *apicommon.Backoff) (*wait.Backoff, error) { | |||
| return &result, nil | |||
| } | |||
|
|
|||
| func Connect(backoff *apicommon.Backoff, conn func() error) error { | |||
| func DoWithRetry(backoff *apicommon.Backoff, f func() error) error { | |||
whynowy
changed the title
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
sarabala1979
approved these changes
Sep 26, 2022
whynowy
added a commit
that referenced
this pull request
Sep 28, 2022
Signed-off-by: Derek Wang <[email protected]>
denis-codefresh
added a commit
to codefresh-io/argo-events
that referenced
this pull request
Aug 28, 2023
* chore(deps): bump github.com/nats-io/nats.go from 1.16.0 to 1.17.0 (argoproj#2197) Bumps [github.com/nats-io/nats.go](https://github.com/nats-io/nats.go) from 1.16.0 to 1.17.0. - [Release notes](https://github.com/nats-io/nats.go/releases) - [Commits](nats-io/nats.go@v1.16.0...v1.17.0) Signed-off-by: Derek Wang <[email protected]> --- updated-dependencies: - dependency-name: github.com/nats-io/nats.go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Emissary executor reads and writes to WorkflowTaskResults, not Pods (argoproj#2189) Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: Julie Vogelman <[email protected]> * fix filter for github sensor example (argoproj#2188) Signed-off-by: Matthieu Simon <[email protected]> Signed-off-by: Matthieu Simon <[email protected]> * chore: enable jetstream 2.9 (argoproj#2205) Signed-off-by: Derek Wang <[email protected]> * chore: fix examples to drop deprecated fields (argoproj#2204) Signed-off-by: Derek Wang <[email protected]> * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.81 to 1.44.105 (argoproj#2208) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump google.golang.org/api from 0.93.0 to 0.97.0 (argoproj#2211) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/stale from 5 to 6 (argoproj#2213) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: Kafka es discontinues processing if eb publishing fails (argoproj#2214) Signed-off-by: Derek Wang <[email protected]> * Make port configurable in webhook, default is set to 443 (argoproj#2215) Signed-off-by: Nir Shtein <[email protected]> * chore: enable argo v3.4 and nats 2.9.1 (argoproj#2216) Signed-off-by: Derek Wang <[email protected]> * Update manifests to v1.7.3 Signed-off-by: Derek Wang <[email protected]> * update versions * fix compile errors * use quay.io/denis_codefresh/argo-events * Revert "use quay.io/denis_codefresh/argo-events" This reverts commit 9fcb428. * fix release * change image across manifests * quay.io/denis_codefresh/argo-events * Revert "quay.io/denis_codefresh/argo-events" This reverts commit 624f792. --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: Matthieu Simon <[email protected]> Signed-off-by: Derek Wang <[email protected]> Signed-off-by: Nir Shtein <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julie Vogelman <[email protected]> Co-authored-by: Matthieu Simon <[email protected]> Co-authored-by: Derek Wang <[email protected]> Co-authored-by: Nir Shtein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang [email protected]
github.com/pkg/errorsChecklist: