Boolean circuit for event dependencies #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavPage
changed the title
magaldima
reviewed
Feb 3, 2019
|
|
||
| // canExecuteTrigger determines whether a trigger is executable based on condition set on trigger | ||
| func (sec *sensorExecutionCtx) canExecuteTrigger(trigger v1alpha1.Trigger) bool { | ||
| if trigger.When == nil { |
There was a problem hiding this comment.
so does this make this change non-breaking? for existing sensors defined without groups or when this will still allow the trigger to fire?
There was a problem hiding this comment.
Yeah, this is a non breaking change. If sensor doesn’t define groups, it will follow old logic of ANDing all events. ‘when’ on triggers is completely optional as well
| sec.log.Error().Err(err).Msg("failed to create K8s event to log trigger execution round completion") | ||
| } | ||
|
|
||
| // Mark all dependency nodes as active |
There was a problem hiding this comment.
so every trigger execution resets the sensor nodes to active so that this sensor can be triggered again.?
There was a problem hiding this comment.
Every round of triggers resets the sensor nodes back to active state
magaldima
approved these changes
Feb 4, 2019
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* Moving EventProtocol to api common * Moving EventProtocol to api common * Added support to declare dependency groups and circuit expression * AAdded DependencyGroups as separate entity from Dependencies * Validating every sensor file and other chores * Added conditions for triggers * Validating every sensor file and other chores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12