Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite revisionHistoryLimit for Sensor Deployment #1786

Closed
nice-pink opened this issue Mar 30, 2022 · 1 comment · Fixed by #2244
Closed

Overwrite revisionHistoryLimit for Sensor Deployment #1786

nice-pink opened this issue Mar 30, 2022 · 1 comment · Fixed by #2244
Labels
enhancement New feature or request

Comments

@nice-pink
Copy link

Is your feature request related to a problem? Please describe.
When working on the sensors the ArgoCD UI gets pretty messy showing all these old sensor replica sets. It would be nice to be able to set the revisionHistoryLimit of the sensor deployment.

Describe the solution you'd like
Use revisionHistoryLimit in sensor to overwrite/set revisionHistoryLimit in sensor deployment.

apiVersion: argoproj.io/v1alpha1
kind: Sensor
metadata:
  name: sensor-name
spec:
  revisionHistoryLimit: 0
  template:
    serviceAccountName: argo-events-sa

Describe alternatives you've considered
Set default revisionHistoryLimit in a global argo-events config.

Additional context


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@tooptoop4
Copy link
Contributor

can eventsource be overwritten?

bilalba pushed a commit to intuit-data-os/argo-events that referenced this issue Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants