feat: Controller Leader Election (#1883)

* Issue 1565: Controller Leader Election Signed-off-by: David Collom <[email protected]> * Fix up RBAC Signed-off-by: David Collom <[email protected]> * Adding coordination/leases to install/namespace-install Signed-off-by: David Collom <[email protected]> * Fix up rbac Signed-off-by: David Collom <[email protected]> * Adding additional RBAC for Events Signed-off-by: David Collom <[email protected]>
argoproj · Apr 22, 2022 · 8a97852 · 8a97852
1 parent 66cb7c4
commit 8a97852
Show file tree

Hide file tree

Showing 5 changed files with 78 additions and 0 deletions.
diff --git a/controllers/cmd/start.go b/controllers/cmd/start.go
@@ -46,6 +46,8 @@ func Start(namespaced bool, managedNamespace string) {
 	opts := ctrl.Options{
 		MetricsBindAddress:     fmt.Sprintf(":%d", common.ControllerMetricsPort),
 		HealthProbeBindAddress: ":8081",
+		LeaderElection:         true,
+		LeaderElectionID:       "argo-events-controller",
 	}
 	if namespaced {
 		opts.Namespace = managedNamespace

diff --git a/manifests/cluster-install/rbac/argo-events-cluster-role.yaml b/manifests/cluster-install/rbac/argo-events-cluster-role.yaml
@@ -3,6 +3,25 @@ kind: ClusterRole
 metadata:
   name: argo-events-role
 rules:
+  - apiGroups:
+    - ""
+    resources:
+    - "events"
+    verbs:
+      - "create"
+      - "patch"
+  - apiGroups:
+      - coordination.k8s.io
+    resources:
+      - leases
+    verbs:
+      - get
+      - list
+      - watch
+      - create
+      - update
+      - patch
+      - delete
   - apiGroups:
       - argoproj.io
     verbs:

diff --git a/manifests/install.yaml b/manifests/install.yaml
@@ -211,6 +211,25 @@ kind: ClusterRole
 metadata:
   name: argo-events-role
 rules:
+- apiGroups:
+  - ""
+  resources:
+  - events
+  verbs:
+  - create
+  - patch
+- apiGroups:
+  - coordination.k8s.io
+  resources:
+  - leases
+  verbs:
+  - get
+  - list
+  - watch
+  - create
+  - update
+  - patch
+  - delete
 - apiGroups:
   - argoproj.io
   resources:

diff --git a/manifests/namespace-install.yaml b/manifests/namespace-install.yaml
@@ -130,6 +130,25 @@ metadata:
   name: argo-events-role
   namespace: argo-events
 rules:
+- apiGroups:
+  - ""
+  resources:
+  - events
+  verbs:
+  - create
+  - patch
+- apiGroups:
+  - coordination.k8s.io
+  resources:
+  - leases
+  verbs:
+  - get
+  - list
+  - watch
+  - create
+  - update
+  - patch
+  - delete
 - apiGroups:
   - argoproj.io
   resources:

diff --git a/manifests/namespace-install/rbac/argo-events-role.yaml b/manifests/namespace-install/rbac/argo-events-role.yaml
@@ -3,6 +3,25 @@ kind: Role
 metadata:
   name: argo-events-role
 rules:
+  - apiGroups:
+    - ""
+    resources:
+    - "events"
+    verbs:
+      - "create"
+      - "patch"
+  - apiGroups:
+      - coordination.k8s.io
+    resources:
+      - leases
+    verbs:
+      - get
+      - list
+      - watch
+      - create
+      - update
+      - patch
+      - delete
   - apiGroups:
       - argoproj.io
     verbs: