docs: add comment about current-user-password #7258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not immediately clear what the `<current-user-password>` should be as shown by this issue: #4096. This comment should make it more clear that when users are setting passwords as the default `admin` user, they should be using the `admin` password here. Signed-off-by: John Chen <[email protected]>
alexmt
approved these changes
Sep 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #7258 +/- ##
=======================================
Coverage 41.08% 41.09%
=======================================
Files 160 160
Lines 21475 21475
=======================================
+ Hits 8823 8825 +2
+ Misses 11387 11386 -1
+ Partials 1265 1264 -1
Continue to review full report at Codecov.
|
|
Looks like k3s is having some issues with their signature files. Could this be merged in anyway? |
|
Looks like k3s had an issue. Retrying CI |
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
It is not immediately clear what the `<current-user-password>` should be as shown by this issue: argoproj#4096. This comment should make it more clear that when users are setting passwords as the default `admin` user, they should be using the `admin` password here. Signed-off-by: John Chen <[email protected]> Signed-off-by: viktorplakida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not immediately clear what the
<current-user-password>should be as shown by this issue: #4096.This comment should make it more clear that when users are setting passwords as the default
adminuser, they should be using theadminpassword here.Fixes #4096