Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade npm dependencies to remove vulnerablities #6700

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

saumeya
Copy link
Contributor

@saumeya saumeya commented Jul 12, 2021

Signed-off-by: saumeya [email protected]
Screenshot from 2021-07-12 21-44-34

  • Install Snyk CLI (npm install snyk)
  • Re-run snyk tests (e.g. snyk test --file=ui/package.json)

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@saumeya
Copy link
Contributor Author

saumeya commented Jul 12, 2021

@jannfis @keithchong Please review

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you

@saumeya
Copy link
Contributor Author

saumeya commented Jul 12, 2021

LGTM. thank you

Thanks :)

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #6700 (9b43cfd) into master (f12650c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6700   +/-   ##
=======================================
  Coverage   41.29%   41.30%           
=======================================
  Files         156      156           
  Lines       20688    20702   +14     
=======================================
+ Hits         8543     8550    +7     
- Misses      10937    10944    +7     
  Partials     1208     1208           
Impacted Files Coverage Δ
cmd/argocd-util/commands/app.go 31.30% <0.00%> (-0.28%) ⬇️
cmd/argocd/commands/root.go 2.17% <0.00%> (-0.05%) ⬇️
util/settings/settings.go 47.00% <0.00%> (ø)
cmd/argocd/commands/app.go 0.00% <0.00%> (ø)
cmd/util/app.go 36.87% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12650c...9b43cfd. Read the comment docs.

@alexmt alexmt merged commit d6dd6af into argoproj:master Jul 12, 2021
@rbreeze rbreeze mentioned this pull request Jul 12, 2021
@saumeya saumeya deleted the npm-vulnerable branch November 10, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants