fix: Application list page filter counts are confusing (#6625) #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6626 +/- ##
=======================================
Coverage 41.29% 41.30%
=======================================
Files 156 156
Lines 20688 20688
=======================================
+ Hits 8543 8545 +2
+ Misses 10937 10936 -1
+ Partials 1208 1207 -1
Continue to review full report at Codecov.
|
rbreeze
approved these changes
Jul 2, 2021
Signed-off-by: Alexander Matyushentsev <[email protected]>
alexmt
force-pushed
the
list-filter-counts
branch
from
ee48f39 to
9caf75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev [email protected]
Closes #6625
The Health and Sync filter counts should take into account applied filters: If user changes project/label etc then counts should take into account applied filter. Filter should not affect own counts. E.g. Sync filter should not affect Sync filter counts.
Screen.Recording.2021-07-02.at.11.57.22.AM.mov