-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): Add health checks for CustomResourceDefinitions (CRDs) #21323
feat(controller): Add health checks for CustomResourceDefinitions (CRDs) #21323
Conversation
Signed-off-by: chansuke <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: chansuke <[email protected]>
f2bd4f7
to
b938ca4
Compare
Signed-off-by: chansuke <[email protected]>
7305314
to
adbf586
Compare
Signed-off-by: chansuke <[email protected]>
79715bd
to
8c71fb8
Compare
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
47974ac
to
4b95de7
Compare
Signed-off-by: chansuke <[email protected]>
4b95de7
to
6680ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the failing tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look at https://argo-cd.readthedocs.io/en/stable/operator-manual/health/#way-2-contribute-a-custom-health-check
I don't think adding the CRD check Should require modifications to any controller code
Closing in favor of Lua alternative: #21416 |
Closes #21119
Checklist: