Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update the repository path url to a valid value #20956

Closed

Conversation

revitalbarletz
Copy link
Contributor

@revitalbarletz revitalbarletz commented Nov 26, 2024

The path values should be either helm-guestbook or kustomize-guestbook instead of just guestbook. Fixed the tutorial accordignly as well as updated the image to include the right values.

Issue: #20822.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Revital Barletz <[email protected]>
@revitalbarletz revitalbarletz requested review from a team as code owners November 26, 2024 09:18
Copy link

bunnyshell bot commented Nov 26, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@revitalbarletz
Copy link
Contributor Author

It does not work with guestbook, I am not able to create the application.

@blakepettersson
Copy link
Member

@revitalbarletz this manifest works for me using guestbook

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: guestbook
  namespace: argocd
spec:
  destination:
    namespace: guestbook
    server: 'https://kubernetes.default.svc'
  sources:
  - path: guestbook
    repoURL: 'https://github.com/argoproj/argocd-example-apps'
  project: default
  syncPolicy:
    automated:
      prune: true
    syncOptions:
      - CreateNamespace=true
      - PrunePropagationPolicy=foreground
      - PruneLast=true

@nitishfy
Copy link
Member

nitishfy commented Dec 2, 2024

For me it works with guestbook too.

project: default
source:
  repoURL: https://github.com/argoproj/argocd-example-apps
  path: guestbook
  targetRevision: HEAD
destination:
  server: https://kubernetes.default.svc
  namespace: default

If it doesn't show you the guestbook path on the UI, try inserting the path manually instead.
image

@revitalbarletz
Copy link
Contributor Author

Thank you @nitishfy for checking this out. I Will debug my failure and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants