fix(docs): Update the repository path url to a valid value #20956
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Revital Barletz <[email protected]>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
nitishfy
reviewed
Nov 26, 2024
| @@ -170,7 +170,7 @@ Give your app the name `guestbook`, use the project `default`, and leave the syn | |||
|
|
|||
|  | |||
|
|
|||
| Connect the [https://github.com/argoproj/argocd-example-apps.git](https://github.com/argoproj/argocd-example-apps.git) repo to Argo CD by setting repository url to the github repo url, leave revision as `HEAD`, and set the path to `guestbook`: | |||
| Connect the [https://github.com/argoproj/argocd-example-apps.git](https://github.com/argoproj/argocd-example-apps.git) repo to Argo CD by setting repository url to the github repo url, leave revision as `HEAD`, and set the path to either `helm-guestbook` or `kustomize-guestbook`: | |||
There was a problem hiding this comment.
Suggested change
| Connect the [https://github.com/argoproj/argocd-example-apps.git](https://github.com/argoproj/argocd-example-apps.git) repo to Argo CD by setting repository url to the github repo url, leave revision as `HEAD`, and set the path to either `helm-guestbook` or `kustomize-guestbook`: | |
| Connect the [https://github.com/argoproj/argocd-example-apps.git](https://github.com/argoproj/argocd-example-apps.git) repo to Argo CD by setting repository url to the github repo url, leave revision as `HEAD`, and set the path to either `helm-guestbook` or `kustomize-guestbook`: |
why set to helm-guestbook or kustomize-guestbook? The guestbook path exists in the repo url already.
There was a problem hiding this comment.
When I set to guestbook only it does not work and it does not appear in the UI. Does it work for you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path values should be either helm-guestbook or kustomize-guestbook instead of just guestbook. Fixed the tutorial accordignly as well as updated the image to include the right values.
Issue: #20822.
Checklist: