Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Confluent Connector Resource Health Checker - #17695 #17697

Merged
merged 5 commits into from
Dec 15, 2024
Merged

feat: Confluent Connector Resource Health Checker - #17695 #17697

merged 5 commits into from
Dec 15, 2024

Conversation

Clint-Chester
Copy link
Contributor

@Clint-Chester Clint-Chester commented Apr 2, 2024 •
edited
Loading

This closes #17695. There was a custom health checker for Confluent Connect, but nothing for the Connectors, so this adds that as per the Argo Guide.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@Clint-Chester Clint-Chester requested review from a team as code owners April 2, 2024 06:39
crenshaw-dev
crenshaw-dev reviewed Apr 2, 2024
View reviewed changes
resource_customizations/platform.confluent.io/Connector/health.lua Outdated
if obj.status.state == "ERROR" then
hs.status = "Degraded"
for i, condition in ipairs(obj.status.conditions) do
hs.message = condition.message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this cause the health check message to just match whatever is the last message in the conditions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it would in its current form. Open to suggestions of what would be preferred 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it completely depends on the resource. The health check should take all relevant conditions into account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crenshaw-dev I've gone through and double checked a number of Connector failure scenarios with this Confluent Operator. Even though conditions is an array, it was only generating one condition each time. In addition, the message being returned in that condition encapsulates all the error messages within that condition. Therefore I've updated the logic and test scenario to mimic the scenario of what's happening. Let me know if any further changes are needed.

@Clint-Chester Clint-Chester reopened this Sep 21, 2024
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 21, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 21, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@Clint-Chester Clint-Chester reopened this Sep 21, 2024
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 21, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 21, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@Clint-Chester Clint-Chester force-pushed the master branch 2 times, most recently from e56c014 to 92497df Compare September 21, 2024 09:21
@codecov Codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.17%. Comparing base (a7ff791) to head (5f50a9f).
Report is 141 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #17697      +/-   ##
==========================================
- Coverage   55.19%   55.17%   -0.02%     
==========================================
  Files         324      324              
  Lines       55257    55257              
==========================================
- Hits        30499    30490       -9     
- Misses      22137    22156      +19     
+ Partials     2621     2611      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Clint-Chester Clint-Chester force-pushed the master branch 2 times, most recently from 4690822 to 4e1f8d9 Compare November 8, 2024 02:46
crenshaw-dev
crenshaw-dev approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on the review!

@crenshaw-dev crenshaw-dev merged commit 99efafb into argoproj:master Dec 15, 2024
27 checks passed
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
@Clint-Chester @dudo
feat: Confluent Connector Resource Health Checker - argoproj#17695 (a…
4b23978 
…rgoproj#17697)

* Adding Synergy as a ArgoCD user

Signed-off-by: GitHub <[email protected]>

* Health checking Kafka Connector resources

Signed-off-by: Clint Chester <[email protected]>

* Includes Kafka Connect Task Failures

Signed-off-by: Clint Chester <[email protected]>

---------

Signed-off-by: GitHub <[email protected]>
Signed-off-by: Clint Chester <[email protected]>
Signed-off-by: Brett C. Dudo <[email protected]>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@Clint-Chester @revitalbarletz
feat: Confluent Connector Resource Health Checker - argoproj#17695 (a…
70cbbb0 
…rgoproj#17697)

* Adding Synergy as a ArgoCD user

Signed-off-by: GitHub <[email protected]>

* Health checking Kafka Connector resources

Signed-off-by: Clint Chester <[email protected]>

* Includes Kafka Connect Task Failures

Signed-off-by: Clint Chester <[email protected]>

---------

Signed-off-by: GitHub <[email protected]>
Signed-off-by: Clint Chester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Health Check - Confluent Connector
2 participants
@Clint-Chester @crenshaw-dev