-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance ArgoCD CLI: Dynamic Repo Server Retrieval with --core and --refresh Flags #17613
Merged
ishitasequeira
merged 19 commits into
argoproj:master
from
Mangaal:argocd-cli-core-flag
Mar 29, 2024
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
87bc574
add const key value for ComponentRepoServer
Mangaal 4987796
update NewRepoServerClient() to look for service with ComponentRepoS…
Mangaal 29b0e7a
add comment for the new constants
Mangaal 3b060b4
Merge branch 'master' of https://github.com/Mangaal/argo-cd into argo…
Mangaal 5319368
Merge branch 'master' into argocd-cli-core-flag
Mangaal f67255d
Merge branch 'argocd-cli-core-flag' of https://github.com/Mangaal/arg…
Mangaal 69713b1
Merge branch 'master' into argocd-cli-core-flag
Mangaal ec4b22a
instead of passing nil which leads to nil ptr referance error, pass …
Mangaal dde9a3e
check for operator install repo server name
Mangaal eb41e7c
handle empty nil ptr dereference error
Mangaal 22e28e2
Merge branch 'argocd-cli-core-flag' of https://github.com/Mangaal/arg…
Mangaal 2610292
Merge branch 'master' into argocd-cli-core-flag
Mangaal 6049c22
Merge branch 'master' into argocd-cli-core-flag
Mangaal 4c30993
Merge branch 'argocd-cli-core-flag' of https://github.com/Mangaal/arg…
Mangaal 58a7e28
handle nil prt dereference
Mangaal 4b1ccee
Merge branch 'master' into argocd-cli-core-flag
Mangaal fdba5b1
Merge branch 'argocd-cli-core-flag' of https://github.com/Mangaal/arg…
Mangaal d051cab
typo correction
Mangaal 39e5371
run clidocsgen
Mangaal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of deriving the argocd instance name from the services, can we not apply the label
app.kubernetes.io/component=repo-server
to thespec.template.metadata
section of the repo server deployment and then use this label to get the right repo server.https://github.com/argoproj/argo-cd/blob/f87897c53c6f04426953f5d3ca781d3240186a60/manifests/base/repo-server/argocd-repo-server-deployment.yaml#L16C9-L16C51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anandf, I will update the implementation and add the labels "app.kubernetes.io/component=repo-server" to repo-server replica pods in the manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to
app.kubernetes.io/component=repo-server
component based label might cause confusion when customer provides argument--repo-server-name
with the name of the argocd instanceargocd-repo-server
. So let's keep the logic of deriving the argocd repo server name from the service name.