Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Helm params with commas now updates local spec #1732

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

simster7
Copy link
Member

When setting Helm parameters with commas (as per #1720), commas are now also escaped in app.Spec.Source.Helm.Parameters. Otherwise, a ComparisonError would arise since the the local spec would be different.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #1732 into master will decrease coverage by 0.1%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1732      +/-   ##
==========================================
- Coverage    34.2%   34.09%   -0.11%     
==========================================
  Files          77       77              
  Lines       11438    11439       +1     
==========================================
- Hits         3912     3900      -12     
- Misses       6985     6999      +14     
+ Partials      541      540       -1
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 0.77% <0%> (-0.01%) ⬇️
util/helm/helm.go 63.3% <100%> (ø) ⬆️
util/webhook/webhook.go 21.34% <0%> (-23.6%) ⬇️
controller/appcontroller.go 39.72% <0%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9cd06...94e2bc8. Read the comment docs.

@alexec alexec merged commit 8729c09 into argoproj:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants