docs(proposal): support for post renderers

[surajnarwade]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[surajnarwade]

fixes

• Support helm post renderers #3698
• Manifest post processors #7623

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.48%. Comparing base (f87897c) to head (e8d3bbc).
Report is 416 commits behind head on master.

❗ Current head e8d3bbc differs from pull request most recent head d532fd7

Please upload reports for the commit d532fd7 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #16749      +/-   ##
==========================================
- Coverage   49.73%   49.48%   -0.25%     
==========================================
  Files         274      271       -3     
  Lines       48948    47728    -1220     
==========================================
- Hits        24343    23620     -723     
+ Misses      22230    21773     -457     
+ Partials     2375     2335      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mikebryant]

While the proposal naming comes from Helm's post-renderer feature, this proposal isn't expecting to use it directly, and indeed has a custom implementation for kustomize.

To be more broadly useful could this be under source.postRenderers instead, applying to any sort of application source? (e.g. you might want to post-render some external repo container kustomize, or some custom plugin)

[crenshaw-dev]

Agreed. I think source.kustomizePatches makes sense.

Whether or not we nest it in a postRenderers list is another question.

[surajnarwade]

make sense, I have moved the postRenderers under the source field now

[surajnarwade]

thanks @mikebryant :) @crenshaw-dev I've moved the struct and also linked the POC.

[surajnarwade]

I have the POC on my fork: surajnarwade/argo-cd@5bb7cd9...a399863 for the same.

[aguckenber-chwy]

Heyo, any ETA on when you may get the feature in? I need to use a private helm chart and customize it which is s a LOT more painful than I expected and my options are either to hack it with Kustomize (i.e. this issue) and a Plugin, else if this feature is very soon going to be released I would just use this :)

[mikebryant]

@crenshaw-dev Is there anything more we need to do here, or can this proposal be accepted?

[surajnarwade]

@crenshaw-dev Is there anything more we need in this proposal, can you review again please, TIA 🙏

[zachaller]

I feel like this could be done via a CMP not?

[todaywasawesome]

I agree, this is what CMPs are for.

[afarbos]

I feel like this could be done via a CMP not?

Can you send what argocd generate into a CMP?

If it's straightforward maybe this should be an option in the argocd helm chart seeing with the demand for it. It does not seems has straightforward to me between file management, patches to generate and more.