-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken link #16722
docs: fix broken link #16722
Conversation
Signed-off-by: Noam Gal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16722 +/- ##
==========================================
- Coverage 49.49% 49.48% -0.01%
==========================================
Files 271 271
Lines 47728 47728
==========================================
- Hits 23622 23620 -2
- Misses 21772 21773 +1
- Partials 2334 2335 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In triggers.md file there is function.md file is imported . Can you include these changes also
.Here the underlined URLs need to be updated ,for e.g. https://golang.org/pkg/time/#Time should be updated to https://golang.org/pkg/time#Time (no slash after time) , https://golang.org/pkg/time/#Now should be updated to https://golang.org/pkg/time#Now (no slash after time) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Those links redirect to the proper urls so is fine IMO. Perhaps for another PR? |
Signed-off-by: Noam Gal <[email protected]> Signed-off-by: sshenoy6 <[email protected]>
Signed-off-by: Noam Gal <[email protected]> Signed-off-by: hbc <[email protected]>
Signed-off-by: Noam Gal <[email protected]> Signed-off-by: ebuildy <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]> Signed-off-by: penglongli <[email protected]>
Signed-off-by: Noam Gal <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
Checklist: