-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): fix build, prepare for google analytics v4 (#10850) #11248
Conversation
Signed-off-by: Alex Eftimie <[email protected]>
Codecov ReportBase: 45.64% // Head: 45.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11248 +/- ##
=======================================
Coverage 45.64% 45.64%
=======================================
Files 239 239
Lines 28991 28991
=======================================
Hits 13233 13233
Misses 13939 13939
Partials 1819 1819 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested these changes locally, and the docs build fine now \o/.
Signed-off-by: Alex Eftimie <[email protected]>
Signed-off-by: Alex Eftimie <[email protected]>
Thanks for this update @alexef and @crenshaw-dev! ✨ |
…) (argoproj#11248) * fix docs build. prepare for google analytics v4 Signed-off-by: Alex Eftimie <[email protected]> * fix build Signed-off-by: Alex Eftimie <[email protected]> * fix build codegen check Signed-off-by: Alex Eftimie <[email protected]> Signed-off-by: Alex Eftimie <[email protected]>
…) (argoproj#11248) * fix docs build. prepare for google analytics v4 Signed-off-by: Alex Eftimie <[email protected]> * fix build Signed-off-by: Alex Eftimie <[email protected]> * fix build codegen check Signed-off-by: Alex Eftimie <[email protected]> Signed-off-by: Alex Eftimie <[email protected]>
…) (argoproj#11248) * fix docs build. prepare for google analytics v4 Signed-off-by: Alex Eftimie <[email protected]> * fix build Signed-off-by: Alex Eftimie <[email protected]> * fix build codegen check Signed-off-by: Alex Eftimie <[email protected]> Signed-off-by: Alex Eftimie <[email protected]> Signed-off-by: emirot <[email protected]>
Signed-off-by: Alex Eftimie [email protected]
fixes: #10850
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: