Issue #937 - Use redis as a shared throwaway cache #1120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 37.32% 37.04% -0.29%
==========================================
Files 53 53
Lines 7729 7734 +5
==========================================
- Hits 2885 2865 -20
- Misses 4414 4440 +26
+ Partials 430 429 -1
Continue to review full report at Codecov.
|
util/cache/cache.go
Outdated
| } | ||
| client := redis.NewClient(&redis.Options{ | ||
| Addr: redisAddress, | ||
| Password: "", |
There was a problem hiding this comment.
We should consider having a shared password mapped from argocd-secret.
There was a problem hiding this comment.
Agree. Added flag for db and env variable for password
util/cache/cache.go
Outdated
| client := redis.NewClient(&redis.Options{ | ||
| Addr: redisAddress, | ||
| Password: "", | ||
| DB: 0, |
There was a problem hiding this comment.
I think redis DB should also be exposed as a command line flag.
| } | ||
|
|
||
| func appManagedResourcesKey(appName string) string { | ||
| return fmt.Sprintf("app|managed-resources|%s", appName) |
There was a problem hiding this comment.
I think we should consider prefixing something like a db "version" to the keys so that when we make changes to the responses, we bump the version and the cache is automatically invalidated
There was a problem hiding this comment.
This is already implemented in getItem/setItem methods. As we agreed offline switched to separete const for cache version.
alexmt
force-pushed
the
937-redis-cache
branch
from
d91b48c to
f99b163
Compare
Closes #937