-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:A little improve for code #10362
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10362 +/- ##
==========================================
+ Coverage 46.16% 46.27% +0.10%
==========================================
Files 228 228
Lines 28004 27869 -135
==========================================
- Hits 12927 12895 -32
+ Misses 13324 13235 -89
+ Partials 1753 1739 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: xin.li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @my-git9!
Signed-off-by: xin.li <[email protected]> Signed-off-by: xin.li <[email protected]> Signed-off-by: Yi Cai <[email protected]>
* fix: missing actions (#10327) (#10359) Signed-off-by: CI <[email protected]> Signed-off-by: CI <[email protected]> Signed-off-by: Yi Cai <[email protected]> * chore: infer managed resources health from redis instead of storing it in CRD (#10191) * chore: infer managed resources health from redis instead of storing it in CRD Signed-off-by: Alexander Matyushentsev <[email protected]> * apply reviewer notes Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Yi Cai <[email protected]> * fix: Add logic to handle for fileHandle.Close() (#9963) (#10361) Signed-off-by: xin.li <[email protected]> Signed-off-by: xin.li <[email protected]> Signed-off-by: Yi Cai <[email protected]> * docs: fix typo in upgrade notes (#10377) Signed-off-by: Xijun Dai <[email protected]> Signed-off-by: Xijun Dai <[email protected]> Signed-off-by: Yi Cai <[email protected]> * fix: add space before prompt in CLI (#10362) Signed-off-by: xin.li <[email protected]> Signed-off-by: xin.li <[email protected]> Signed-off-by: Yi Cai <[email protected]> * docs: fix indentation of example AppProject in 'Sync Windows' documentation (#10388) Signed-off-by: Yi Cai <[email protected]> * fix: Correctly assume cluster-scoped resources to be self-referenced (#10390) Signed-off-by: jannfis <[email protected]> Signed-off-by: jannfis <[email protected]> Signed-off-by: Yi Cai <[email protected]> * ui-make-https-repo-credential-editable Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> * Minor format fix Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> * Minor fix for unclickable input field Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> * Updates for comments Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> * ui-make-https-repo-credential-editable Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> * Minor format fix Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> * Minor fix for unclickable input field Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> * Updates for comments Signed-off-by: ciiay <[email protected]> Signed-off-by: Yi Cai <[email protected]> Signed-off-by: CI <[email protected]> Signed-off-by: Yi Cai <[email protected]> Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: xin.li <[email protected]> Signed-off-by: Xijun Dai <[email protected]> Signed-off-by: jannfis <[email protected]> Signed-off-by: ciiay <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: my-git9 <[email protected]> Co-authored-by: Xijun Dai <[email protected]> Co-authored-by: Jun Duan <[email protected]> Co-authored-by: jannfis <[email protected]>
a little improve for code
Checklist: