Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync operation unnecessary waits for a healthy state of all resources #1715

Closed
alexmt opened this issue Jun 7, 2019 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alexmt
Copy link
Collaborator

alexmt commented Jun 7, 2019

Describe the bug
Sync operation unnecessary waits for a healthy state of all resources even if user has a single "wave"

To Reproduce

  1. Sync any deployment which consist of a single wave.
  2. Sync operation stays in running state until all resources are healty or degraded.

Expected behavior
The last waive should not wait for a healthy state of all resources. This is changing sync operation behavior.

Version: 1.1.0 (unreleased)

@alexmt alexmt added the bug Something isn't working label Jun 7, 2019
@alexec alexec added this to the v1.1 milestone Jun 7, 2019
@alexec
Copy link
Contributor

alexec commented Jun 10, 2019

We should brainstorm this.

Sync waves change how the op status is determined.

At any point during a sync op, including post-sync, we can end up with a situation where we cannot continue (everything is degraded) or progressing (e.g a pod in crash loop backoff). We don't' differentiate recoverable (crashloopbackoff) from unrecoverable (invalidimagename), it means we can't tell if a degraded resource will become healthy. Because these situations, therefore, may resolve, the wave could become healthy, and the op continues.

This could happen a long time after the sync is requested. (By "long" I mean, there'' Git commit that changes the app.

This op will remain in progress until it is terminated:

Screen Shot 2019-06-10 at 11 45 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants