fix(argocd_application): don't flatten spec.info if list is empty
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Maurer <[email protected]>
onematchfox
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
Sorry for the delay here. Crunch time at work and weekends have been full up. Managed to reproduce the issue using the description here and can confirm that this fixes that. Would ideally have liked to have seen some tests but, this would be a bit of a pain to write as it would require simulating UI interaction. So, I think we can go with manual verification for now.
onematchfox
changed the title
spec.info if list is empty
|
FYI: Releases of this project are currently broken due to an issue in argocd. #354 should hopefully address it until argoproj/argo-cd#16388 is reviewed, merged and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
Seems to be an edge case of:
/cc: @onematchfox , @MrLuje