Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argocd_application_set): Add support for pathParamPrefix #336

Merged
merged 11 commits into from
Sep 14, 2023
Merged

feat(argocd_application_set): Add support for pathParamPrefix #336

merged 11 commits into from
Sep 14, 2023

Conversation

ahublersos
Copy link
Contributor

@ahublersos ahublersos commented Sep 12, 2023 •
edited
Loading

Fixes (#329).

This PR adds support for the pathParamPrefix parameter in the git generator.

@ahublersos ahublersos marked this pull request as ready for review September 12, 2023 11:45
@ahublersos
Copy link
Contributor Author

Test is failing with v2.5.18, which makes sense since the feature was released in v2.6. @onematchfox since ArgoCD 2.6 is the new minimum supported version for the provider, can we remove the v2.5.18 acceptance tests and maybe replace them with a version running v2.8.x?

@onematchfox
Copy link
Collaborator

Test is failing with v2.5.18, which makes sense since the feature was released in v2.6. @onematchfox since ArgoCD 2.6 is the new minimum supported version for the provider, can we remove the v2.5.18 acceptance tests and maybe replace them with a version running v2.8.x?

Yeah sure, I'll push a commit to your branch to adjust this (and a couple nits that I spotted when looking at the changes you've made).

@onematchfox onematchfox self-requested a review September 12, 2023 14:24
@onematchfox
Copy link
Collaborator

@ahublersos thanks so much for submitting this. I'm going to merge now. Do you want this released immediately or are you working on something else?

@onematchfox onematchfox merged commit d84d091 into argoproj-labs:master Sep 14, 2023
6 checks passed
@ahublersos
Copy link
Contributor Author

@ahublersos thanks so much for submitting this. I'm going to merge now. Do you want this released immediately or are you working on something else?

Happy to help! No rush from me to release, I do plan to work on #333 in the next few days.

@onematchfox
Copy link
Collaborator

I do plan to work on #333 in the next few days.

That would be amazing. The help is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onematchfox onematchfox onematchfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for pathParamPrefix in argocd_application_set
2 participants
@ahublersos @onematchfox