add: project scope support for clusters #143
Conversation
docs/resources/cluster.md
Outdated
| @@ -121,6 +121,7 @@ resource "argocd_cluster" "eks" { | |||
| * `namespaces` - (Optional) Holds list of namespaces which are accessible in that cluster. Cluster level resources would be ignored if namespace list is not empty.. | |||
| * `config` - (Optional) The configuration specification, nested attributes are documented below. | |||
| * `metadata` - (Optional) Cluster metadata, nested attributes are documented below. | |||
| * `project` - (Optional) Scope cluster to ArgoCD project. If omitted, cluster will be global. | |||
There was a problem hiding this comment.
Maybe add a version requirement comment here, and what happens if the field is added on argocd versions < 2.2
There was a problem hiding this comment.
2.2.0 being required has been added. Also, based on how the application resource does it I added a new feature to the constraints map so if the setting is used with an older version it errors out.
Useful for acceptance tests that should only be run when specific features are supported by ArgoCD version. If a feature is not supported the test is skipped, not failed.
alxbse
force-pushed
the
add-project-to-cluster
branch
from
c59807e to
9f7503e
Compare
alxbse
force-pushed
the
add-project-to-cluster
branch
from
9f7503e to
0148af3
Compare
|
I was looking around in other terraform providers if there are any establish ways of doing prechecks that check server versions but have not been able to find any yet. I added a slightly hackish precheck function that uses the constraints map to compare what version is required for the acceptance test to run. It uses the ARGOCD_VERSION environment variable to figure out what version it is running against, which is not the nicest solution. Would it be possible to access the actual provider and the initialized ServerInterface from any function? It would be nicer to get the actual version from the server using the isFeatureSupported function. |
|
Looking at how github.com/hashicorp/terraform-provider-vsphere does it I added an alternative implementation of the precheck function in alxbse/terraform-provider-argocd@2e5f71d. It is still kinda hacky but atleast it uses the same isFeatureSupported function call. It feels like I'm get further away from the actual issue of adding support for project scope, should I maybe close this PR for now to sort out prechecking in another one? |
|
As you mentioned, we would need to establish another ServerInterface just for the tests. Your solution is acceptable, and the impact on local testing is minimal. For now I think that will do, we can indeed tackle this issue in another PR. |
Adds support for project scoped clusters: https://argo-cd.readthedocs.io/en/stable/user-guide/projects/#project-scoped-repositories-and-clusters
I'm deliberately adding an acceptance tests that breaks with 2.1.0 because that version does not have support for scoped clusters, any ideas on how to deal with tests that require at least some version of argocd? I'm thinking if adding a precheck function to check the argocd version and skip if it is not compatible could be a good solution?