-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to reconcile multiple RolloutMangers #65
Conversation
Signed-off-by: Rizwana777 <[email protected]>
I have added the iteration logic in Reconcile function itself, the example mention in the issue have a separate function which is called in SetupWithManager function, please do let me know if the logic I have added is correct or not, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a commit that takes a different approach to reconciling multiple RolloutManagers:
- In general, one RolloutManager should not modify the status of another RolloutManager.
- Instead, we can use the watch api to ensure that reconcile is called on all RolloutManagers whenever the another RolloutManager changes significantly (hinted at this approach in the original issue)
I've pushed a commit which does this, take a look and let me know if you see any issues. If not, we can clean up the resulting commit and then we are good to go.
I see no issues Jonathan, I have used |
Signed-off-by: Jonathan West <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Rizwana777!
What does this PR do / why we need it:
JIRA - https://issues.redhat.com/browse/GITOPS-4766