Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run upstream Argo Rollouts E2E tests on argo-rollouts-manager PRs #30

Closed
jgwest opened this issue Jan 24, 2024 · 1 comment · Fixed by #31
Closed

Run upstream Argo Rollouts E2E tests on argo-rollouts-manager PRs #30

jgwest opened this issue Jan 24, 2024 · 1 comment · Fixed by #31
Assignees
@jgwest
Labels
enhancement New feature or request

Comments

@jgwest
Copy link
Member

jgwest commented Jan 24, 2024

All argo-rollout-manager PRs should have the upstream Argo Rollouts E2E tests run against them.

Not all of the Argo Rollouts E2E tests will work when tested in this configuration, so we can maintain a 'deny list' of tests to ignore (tests that are expected to fail).

The version of Argo Rollouts that we run the E2E tests from should correspond to the same upstream Argo Rollouts version that argo-rollouts-manager is installing.
@jgwest jgwest self-assigned this Jan 24, 2024
@jgwest jgwest added the enhancement New feature or request label Jan 24, 2024
jgwest added a commit to jgwest/argo-rollouts-manager that referenced this issue Jan 24, 2024
@jgwest
Run upstream Argo Rollouts E2E tests on argo-rollouts-manager PRs (ar…
29ed956 
…goproj-labs#30)

Signed-off-by: Jonathan West <[email protected]>
@jgwest jgwest mentioned this issue Jan 24, 2024
Merged
1 task
jgwest added a commit to jgwest/argo-rollouts-manager that referenced this issue Jan 24, 2024
@jgwest
Run upstream Argo Rollouts E2E tests on argo-rollouts-manager PRs (ar…
7ef7307 
…goproj-labs#30)

Signed-off-by: Jonathan West <[email protected]>
@jgwest
Copy link
Member Author

jgwest commented Jan 25, 2024

Red Hat JIRA Tracker: https://issues.redhat.com/browse/GITOPS-3914

jgwest added a commit that referenced this issue Jan 26, 2024
@jgwest
Merge pull request #31 from jgwest/add-rollouts-e2e-tests
1a40c06 
Run upstream Argo Rollouts E2E tests on argo-rollouts-manager PRs (#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgwest jgwest

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run upstream Argo Rollouts E2E tests on argo-rollouts-manager PRs (#30) jgwest/argo-rollouts-manager
1 participant
@jgwest