Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated damage and horror tokens #836

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Updated damage and horror tokens #836

merged 10 commits into from
Sep 4, 2024

Conversation

Chr1Z93
Copy link
Collaborator

@Chr1Z93 Chr1Z93 commented Aug 17, 2024

  • removed states in favor of an XML button / label
  • enabled clickability for locked tokens
  • updated Tokenmanager to spawn tokens directly with the correct script state instead of callbacks

@Chr1Z93 Chr1Z93 added the optimization Improving something existing label Aug 17, 2024
@Chr1Z93 Chr1Z93 marked this pull request as ready for review August 18, 2024 16:33
@dscarpac
Copy link
Collaborator

I like these but
(1) the button area should be a little smaller because it's still easy to click the button area when you want to move them
(2) mixed feelings about no "1" state

@Chr1Z93
Copy link
Collaborator Author

Chr1Z93 commented Aug 24, 2024

I like these but (1) the button area should be a little smaller because it's still easy to click the button area when you want to move them

Did you notice that the button will be unclickable after a 2s hover? Don't think the button should be smaller

(2) mixed feelings about no "1" state

I'm open about changing it, but this way it's gonna be a less disruptive change since most of the time single tokens will be in use first (and then you don't directly run into the button)

@dscarpac
Copy link
Collaborator

I like these but (1) the button area should be a little smaller because it's still easy to click the button area when you want to move them

Did you notice that the button will be unclickable after a 2s hover? Don't think the button should be smaller

I did notice this after posting, is this what causes there to sometime be a green outline? Regardless, I think 2 seconds is way too long if this hover-wait-move is the intended behavior to move the tokens. Might take some more playtesting / beta channel help but as it is I found this to be a bit frustrating.

@Chr1Z93
Copy link
Collaborator Author

Chr1Z93 commented Aug 24, 2024

I like these but (1) the button area should be a little smaller because it's still easy to click the button area when you want to move them

Did you notice that the button will be unclickable after a 2s hover? Don't think the button should be smaller

I did notice this after posting, is this what causes there to sometime be a green outline? Regardless, I think 2 seconds is way too long if this hover-wait-move is the intended behavior to move the tokens. Might take some more playtesting / beta channel help but as it is I found this to be a bit frustrating.

This is indeed the intended behaviour. How often do you need to move a damage token on count 2 or above?

@dscarpac
Copy link
Collaborator

I like these but (1) the button area should be a little smaller because it's still easy to click the button area when you want to move them

Did you notice that the button will be unclickable after a 2s hover? Don't think the button should be smaller

I did notice this after posting, is this what causes there to sometime be a green outline? Regardless, I think 2 seconds is way too long if this hover-wait-move is the intended behavior to move the tokens. Might take some more playtesting / beta channel help but as it is I found this to be a bit frustrating.

This is indeed the intended behaviour. How often do you need to move a damage token on count 2 or above?

Not a ton, especially if you use the discard buttons/hotkeys, but certainly not all of our users do. There are plenty of "heal 2" effects that happen and I am sure most users just drop those tokens in the trash. I see your point and agree that these can be something like the resource counters, so there is precedent, but I think this is a big enough change to the simple idea that damage/horror have been moveable tokens forever that I need to see some more feedback from others and playtesting of actual scenarios myself before I can support these exact parameters. (I want to try this out with 1s of hover instead of 2 to see if that feels better).

@dscarpac dscarpac merged commit 803d9a9 into main Sep 4, 2024
1 check passed
@dscarpac dscarpac deleted the damage-horror branch September 4, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Improving something existing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Update damage and horror tokens with proper buttons instead of states
2 participants