Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deck-checking for "Forced Learning" #645

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Conversation

Chr1Z93
Copy link
Collaborator

@Chr1Z93 Chr1Z93 commented Apr 11, 2024

Playmat will now check decks for forced learning (e.g. the set-aside pile of permanents)

@Chr1Z93 Chr1Z93 added the enhancement New feature or request label Apr 11, 2024
@Entrox-Licher
Copy link
Collaborator

This was an intentional omission on my part from the original PR. With slots already at a premium, I don't love implying the need for this to take one up to track something the mod already does automatically. I think the more elegant solution would be to 'fan out' rather than stack the permanents on the side of the player mat.

@Chr1Z93
Copy link
Collaborator Author

Chr1Z93 commented Apr 13, 2024

This was an intentional omission on my part from the original PR. With slots already at a premium, I don't love implying the need for this to take one up to track something the mod already does automatically. I think the more elegant solution would be to 'fan out' rather than stack the permanents on the side of the player mat.

I see your point. If we don't let it start in play then the upkeep script should just check decks too. I don't like spreading the permanents because there could be a lot of them.

@Chr1Z93 Chr1Z93 changed the title Added startsInPlay to forced learning Added deck-checking for "Forced Learning" Apr 14, 2024
@Chr1Z93
Copy link
Collaborator Author

Chr1Z93 commented Apr 14, 2024

@Entrox-Licher I updated the script to now check decks too.

@Entrox-Licher Entrox-Licher merged commit 85cbb09 into main Apr 14, 2024
1 check passed
@Entrox-Licher Entrox-Licher deleted the start-in-play branch April 14, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants