-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamped Download Window #410
Conversation
I'd recommend making it so the preview window pops up on a single click, and the content spawns on a double click (or add a spawn button in place/below the percentage bar). The hovering to show the preview window can be quite finnicky and error prone, particularly as it is loading in a lot of new images at once that the player doesn't necessarily want/need. |
Additionally, the navigation overlay does not seem to be appearing anymore. The button is still present and can be clicked on, but does not actually display the overlay |
Love the new changes! You mentioned removing the placeholder boxes altogether, is that something you want to do in this PR? Also, any chance you could add a feature that pinged the location of the thing spawned in? And do we maybe want to close the window after something is spawned in? (Not strong opinions on these ones, just musings) |
I think if we want to remove them that can be a separate PR (need to discuss this in the group first). The other two suggestions are good! I think we could also unify the spawn position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one error found, the rest is stylistic changes. Functionality is awesome! Super stoked to have this in the mod, a massive improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's get it in!
Preview:
closes #406