Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped Download Window #410

Merged
merged 19 commits into from
Oct 19, 2023
Merged

Revamped Download Window #410

merged 19 commits into from
Oct 19, 2023

Conversation

Chr1Z93
Copy link
Collaborator

@Chr1Z93 Chr1Z93 commented Oct 13, 2023

Preview:
image

  • added tab buttons to swap content types
  • added automatic refresh onLoad() and tab swap
  • added documentation
  • added preview window
  • removed legacy code

closes #406

@Chr1Z93 Chr1Z93 added the enhancement New feature or request label Oct 13, 2023
@Entrox-Licher
Copy link
Collaborator

I'd recommend making it so the preview window pops up on a single click, and the content spawns on a double click (or add a spawn button in place/below the percentage bar). The hovering to show the preview window can be quite finnicky and error prone, particularly as it is loading in a lot of new images at once that the player doesn't necessarily want/need.

@Entrox-Licher
Copy link
Collaborator

Additionally, the navigation overlay does not seem to be appearing anymore. The button is still present and can be clicked on, but does not actually display the overlay

@Entrox-Licher
Copy link
Collaborator

Love the new changes! You mentioned removing the placeholder boxes altogether, is that something you want to do in this PR?

Also, any chance you could add a feature that pinged the location of the thing spawned in? And do we maybe want to close the window after something is spawned in? (Not strong opinions on these ones, just musings)

@Chr1Z93
Copy link
Collaborator Author

Chr1Z93 commented Oct 16, 2023

Love the new changes! You mentioned removing the placeholder boxes altogether, is that something you want to do in this PR?

Also, any chance you could add a feature that pinged the location of the thing spawned in? And do we maybe want to close the window after something is spawned in? (Not strong opinions on these ones, just musings)

I think if we want to remove them that can be a separate PR (need to discuss this in the group first).

The other two suggestions are good! I think we could also unify the spawn position.

Copy link
Collaborator

@Entrox-Licher Entrox-Licher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one error found, the rest is stylistic changes. Functionality is awesome! Super stoked to have this in the mod, a massive improvement!

src/core/Global.ttslua Outdated Show resolved Hide resolved
src/core/Global.ttslua Show resolved Hide resolved
src/core/Global.ttslua Show resolved Hide resolved
src/core/Global.ttslua Show resolved Hide resolved
Copy link
Collaborator

@Entrox-Licher Entrox-Licher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get it in!

@Entrox-Licher Entrox-Licher merged commit df1c20c into main Oct 19, 2023
1 check passed
@Entrox-Licher Entrox-Licher deleted the download-window branch October 19, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improved download window
2 participants