Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Aurora / Megatron-DeepSpeed docs #623

Merged
merged 13 commits into from
Jan 19, 2025
Merged

docs: Add Aurora / Megatron-DeepSpeed docs #623

merged 13 commits into from
Jan 19, 2025

Conversation

saforem2
Copy link
Member

Changes:

  • Add docs/aurora/data-science/frameworks/megatron-deepspeed.md
  • Modify mkdocs.yml
    • Alphabetize entries in nav / Aurora / Data Science / Frameworks:
      • DeepSpeed
      • LibTorch
      • Megatron-DeepSpeed
      • oneCCL
      • OpenVINO
      • PyTorch
      • PyTorch Geometric (PyG)
      • TensorFlow

@saforem2 saforem2 requested review from felker and hatanp January 16, 2025 00:20
Copy link
Contributor

@Eugene29 Eugene29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions

docs/aurora/data-science/frameworks/megatron-deepspeed.md Outdated Show resolved Hide resolved
docs/aurora/data-science/frameworks/megatron-deepspeed.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Eugene29 Eugene29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished running the code, successful on 1 node with a workaround mentioned in the comments and successful on 2 nodes out-of-the-box.

@felker felker self-requested a review January 19, 2025 04:56
Copy link
Member

@felker felker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🔥 🚀 LGTM

Ready to merge?

@felker felker merged commit 56402d1 into main Jan 19, 2025
1 check passed
@felker felker deleted the aurora-saforem2 branch January 19, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants