Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/container #492

Merged
merged 15 commits into from
Oct 30, 2024
Merged

Feature/container #492

merged 15 commits into from
Oct 30, 2024

Conversation

atanikan
Copy link
Member

  • Moved Path for containers from inside datascience to outside for easier access (as container are more general purpose)
  • Updated documentation of container for Sophia and Polaris
  • Updated documentation for using Python on Sophia

@atanikan atanikan requested a review from felker October 15, 2024 17:14
docs/polaris/containers/containers.md Outdated Show resolved Hide resolved
docs/polaris/data-science-workflows/frameworks/pytorch.md Outdated Show resolved Hide resolved
docs/sophia/containers/containers.md Outdated Show resolved Hide resolved
docs/polaris/containers/containers.md Outdated Show resolved Hide resolved
docs/sophia/containers/containers.md Outdated Show resolved Hide resolved
@atanikan atanikan requested a review from felker October 24, 2024 18:46
@felker felker self-requested a review October 30, 2024 19:04
Copy link
Member

@felker felker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of https://facelessuser.github.io/pymdown-extensions/extensions/snippets/#snippet-sections ! Others should start using this feature

--8<-- [start:commoncontainerdoc]

There are a few leftover stylistic inconsistencies (I really dislike seeing "Tensorflow" instead of "TensorFlow" 😄 ), and I think the referenced https://github.com/argonne-lcf/container-registry could use a big update somday soon, but looks good to me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants