The validate_certs parameter had no effect if the retries parameter w…

…as set. Fix now also sets the parameter correctly in the retry request session

Closes ansible-collections#461

changelogs/fragments/459-validate-certs-fix.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - connection_options - the validate_certs parameter had no effect if the retries parameter was set. Fix now also sets the parameter correctly in the retry request session (https://github.com/ansible-collections/community.hashi_vault/issues/461).

plugins/module_utils/_connection_options.py

@@ -108,7 +108,7 @@ def _filter(k, v):
 
         retry_action = hvopts.pop('retry_action')
         if 'retries' in hvopts:
-            hvopts['session'] = self._get_custom_requests_session(new_callback=self._retry_callback_generator(retry_action), **hvopts.pop('retries'))
+            hvopts['session'] = self._get_custom_requests_session(new_callback=self._retry_callback_generator(retry_action), conopt_verify=self._conopt_verify, **hvopts.pop('retries'))
 
         return hvopts
 
@@ -120,7 +120,7 @@ def process_connection_options(self):
         self._process_option_proxies()
         self._process_option_retries()
 
-    def _get_custom_requests_session(self, **retry_kwargs):
+    def _get_custom_requests_session(self, conopt_verify, **retry_kwargs):
         '''returns a requests.Session to pass to hvac (or None)'''
 
         if not HAS_RETRIES:
@@ -159,6 +159,7 @@ def new(self, **kwargs):
         sess = Session()
         sess.mount("https://", adapter)
         sess.mount("http://", adapter)
+        sess.verify = conopt_verify
 
         return sess