Add script to add/update required filters. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juniset
commented
Apr 28, 2021
juniset
commented
- Remove filter for cSAI and cREP
- Add filters for cUNI and cUSDT
- Add filter for WETH
- Request filter update for Paraswap
- Request filter update for ParaswapUniV2RouterFilter (Uniswap v2)
- Request filter update for UniswapV2UniZapFilter
juniset
force-pushed
the
fix/patch_update_script
branch
from
c140288
to
ded3e47
Compare
olivdb
reviewed
Apr 28, 2021
deployment/10_patch_filters.js
Outdated
| // Update existing filters to Argent Registry | ||
| // ////////////////////////////////// | ||
|
|
||
| const filters = {}; |
There was a problem hiding this comment.
I think you need to initialize it with existing filters:
const filters = {...config.filters};
olivdb
reviewed
Apr 28, 2021
| console.log(`Deploying filter for Compound Underlying ${underlying}`); | ||
| const CompoundFilterWrapper = await CompoundFilter.new(underlying); | ||
| console.log(`Deployed filter for Compound Underlying ${underlying} at ${CompoundFilterWrapper.address}`); | ||
| filters.CompoundFilter.push(CompoundFilterWrapper.address); |
There was a problem hiding this comment.
Will only work if filters has been initialized, see comment above ^
olivdb
reviewed
Apr 28, 2021
| if (underlying === "0x89d24A6b4CcB1B6fAA2625fE562bDD9a23260359" || underlying === "0x1985365e9f78359a9B6AD760e32412f4a445E862") { | ||
| // remove SAI and REP filter | ||
| console.log(`Removing filter for Compound Underlying ${underlying}`); | ||
| await DappRegistryWrapper.removeDapp(0, cToken); |
There was a problem hiding this comment.
Shouldn't we remove the corresponding filters from the filters.CompoundFilter array?
olivdb
approved these changes
Apr 28, 2021
|
👌 |
1 similar comment
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.