forked from chapel-lang/chapel
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request chapel-lang#16342 from ben-albrecht/workaround-tom…
…l-error Work-around TOML bug in mason and add a future for bug TOML module produces a seg fault when parsing a file containing only a comment on linux32 / valgrind configs.\ This was exposed when `mason search` started adding a cache file containing only a comment if a cache file did not exist (chapel-lang#16223). In this PR, we work around this bug by creating an empty cache file instead. Also: - added the `cache.toml` to CLEANFILES to prevent previous runs from interfering with each other in local testing - added a future for the TOML bug - to be debugged in the future. [Reviewed by @ronawho]
- Loading branch information
Showing
5 changed files
with
15 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
use TOML; | ||
|
||
config const str: string = """# Comment"""; | ||
|
||
proc main() { | ||
var TomlData = parseToml(str); | ||
writeln(TomlData); | ||
delete TomlData; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
bug: TOML containing only comments produces memory errors (caught in valgrind) | ||
|
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
mason_home/mason-registry/Bricks/cache.toml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters