Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toward a stable API #31

Merged
merged 24 commits into from
Jun 11, 2023
Merged

Toward a stable API #31

merged 24 commits into from
Jun 11, 2023

Conversation

andrewbranch
Copy link
Collaborator

In the process of implementing #22, I ended up making a lot of forward-looking changes to the internal infrastructure and public API.

I’ve been thinking a lot about next steps toward making the UI more useful, allowing you to dig into specific problems and get a lot more details about them. These API changes lay the groundwork for that. (I also have a friend who’s interested in working with me on the UI, which I’m super excited about.) In the meantime, some of the problem summary descriptions may seem to lack important details for package authors trying to determine exactly what’s going on. I think it’s better to get this (huge) PR merged first and iterate on the UI in the coming weeks.

I am a little concerned that in such a big set of changes and with relatively little test coverage that I might have broken something. I may add some more tests before merging.

Closes #22

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2023

🦋 Changeset detected

Latest commit: 943a258

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@arethetypeswrong/core Minor
@arethetypeswrong/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andrewbranch andrewbranch merged commit 958c3e7 into main Jun 11, 2023
@andrewbranch andrewbranch deleted the checker branch June 11, 2023 16:09
@kachick kachick mentioned this pull request Apr 5, 2024
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn’t check that imports inside the package work
1 participant