Skip to content

Commit

Permalink
n64: reenable isviewer even outside of homebrew mode
Browse files Browse the repository at this point in the history
ISViewer is currently gated by the homebrew mode flag. It seems like
this is not ideal for rom hackers because they would still need a way
to log but homebrew mode is too verbose for them and hide the ISViewer
messages in streams of actual problems in game code that they don't
intend to fix. So restore ISViewer functionality without homebrew mode.
  • Loading branch information
rasky committed Jan 21, 2024
1 parent 322c99c commit 399251b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion ares/n64/cartridge/cartridge.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ auto Cartridge::connect() -> void {

rtc.load();

if(rom.size <= 0x03fe'ffff && system.homebrewMode) {
if(rom.size <= 0x03fe'ffff) {
isviewer.ram.allocate(64_KiB);
isviewer.tracer = node->append<Node::Debugger::Tracer::Notification>("ISViewer", "Cartridge");
isviewer.tracer->setAutoLineBreak(false);
Expand Down
2 changes: 0 additions & 2 deletions ares/n64/pi/bus.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ inline auto PI::busWrite(u32 address, u32 data) -> void {
if(cartridge.isviewer.enabled()) {
writeForceFinish(); //Debugging channel for homebrew, be gentle
return cartridge.isviewer.write<Size>(address, data);
} else if (!system.homebrewMode) {
debug(unhandled, "[PI::busWrite] attempt to write to ISViewer: enable homebrew mode in settings to enable ISViewer emulation");
} else {
debug(unhandled, "[PI::busWrite] attempt to write to ISViewer: ROM is too big so ISViewer is disabled");
}
Expand Down

0 comments on commit 399251b

Please sign in to comment.